Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve documentation for CSI create/register mount_options #10649

Merged
merged 1 commit into from
May 24, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented May 24, 2021

Adds clarification to nomad volume create commands around how the volume
block in the jobspec overrides this behavior. Adds missing section to nomad volume register and to example volume spec for both commands.

Also add a changelog entry for #10643

Preview links:
https://nomad-jyqbf335s-hashicorp.vercel.app/docs/commands/volume/create#mount_options
https://nomad-jyqbf335s-hashicorp.vercel.app/docs/commands/volume/register#mount_options

Adds clarification to `nomad volume create` commands around how the `volume`
block in the jobspec overrides this behavior. Adds missing section to `nomad
volume register` and to example volume spec for both commands.
@tgross tgross marked this pull request as ready for review May 24, 2021 15:01
@tgross tgross requested review from shoenig and notnoop May 24, 2021 15:01
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross tgross merged commit 9135b42 into main May 24, 2021
@tgross tgross deleted the docs-csi-mount-options branch May 24, 2021 15:13
@tgross tgross added the theme/docs Documentation issues and enhancements label May 24, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/docs Documentation issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants