Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add monitor flag to deployment status #10661

Merged
merged 2 commits into from
Jun 9, 2021
Merged

cli: add monitor flag to deployment status #10661

merged 2 commits into from
Jun 9, 2021

Commits on Jun 9, 2021

  1. cli: add monitor flag to deployment status 

    Adding '-verbose' will print out the allocation information for the
deployment. This also changes the job run command so that it now blocks
until deployment is complete and adds timestamps to the output so that
it's more in line with the output of node drain.

This uses glint to print in place in running in a tty. Because glint
doesn't yet support cmd/powershell, Windows workflows use a different
library to print in place, which results in slightly different
formatting: 1) different margins, and 2) no spinner indicating
deployment in progress.
    @isabeldepapel
    isabeldepapel committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    cd95550 View commit details
    Browse the repository at this point in the history

  2. tests: use standard library testing.TB 

    Glint pulled in an updated version of mitchellh/go-testing-interface
which broke some existing tests because the update added a Parallel()
method to testing.T. This switches to the standard library testing.TB
which doesn't have a Parallel() method.
    @isabeldepapel
    Mahmood Ali authored and isabeldepapel committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    bfbaef0 View commit details
    Browse the repository at this point in the history