Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: validate the type flag when querying plugin status. #10712

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jun 7, 2021

closes #10711

@jrasell jrasell added type/bug theme/cli stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Jun 7, 2021
@jrasell jrasell requested review from notnoop and tgross June 7, 2021 11:59
@jrasell jrasell self-assigned this Jun 7, 2021
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jrasell jrasell merged commit bb3a98e into main Jun 7, 2021
@jrasell jrasell deleted the b-gh-10711 branch June 7, 2021 16:14
jrasell added a commit that referenced this pull request Jun 8, 2021
jrasell added a commit that referenced this pull request Jun 8, 2021
jrasell added a commit that referenced this pull request Jun 8, 2021
@notnoop notnoop added this to the 1.1.1 milestone Jun 9, 2021
notnoop pushed a commit that referenced this pull request Jun 9, 2021
cmd: validate the type flag when querying plugin status.
notnoop pushed a commit that referenced this pull request Jun 9, 2021
cmd: validate the type flag when querying plugin status.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd: nomad plugin status command ignores -type flag
3 participants