Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quotas: evaluate quota feasibility last in scheduler #10753

Merged
merged 2 commits into from
Jun 14, 2021
Merged

quotas: evaluate quota feasibility last in scheduler #10753

merged 2 commits into from
Jun 14, 2021

Commits on Jun 14, 2021

  1. quotas: evaluate quota feasibility last in scheduler 

    The `QuotaIterator` is used as the source of nodes passed into feasibility
checking for constraints. Every node that passes the quota check counts the
allocation resources agains the quota, and as a result we count nodes which
will be later filtered out by constraints. Therefore for jobs with
constraints, nodes that are feasibility checked but fail have been counted
against quotas. This failure mode is order dependent; if all the unfiltered
nodes happen to be quota checked first, everything works as expected.

This changeset moves the `QuotaIterator` to happen last among all feasibility
checkers (but before ranking). The `QuotaIterator` will never receive filtered
nodes so it will calculate quotas correctly.
    @tgross
    tgross committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    2757448 View commit details
    Browse the repository at this point in the history

  2. changelog entry

    @tgross
    tgross committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    27134c3 View commit details
    Browse the repository at this point in the history