Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: unset port to field maps to dynamic port #10828

Merged
merged 2 commits into from
Jun 28, 2021
Merged

docs: unset port to field maps to dynamic port #10828

merged 2 commits into from
Jun 28, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented Jun 28, 2021 •
edited
Loading

Fixes #6958 and #9456

@tgross tgross added theme/docs Documentation issues and enhancements theme/networking labels Jun 28, 2021
@tgross tgross requested review from notnoop and shoenig June 28, 2021 19:46
shoenig
shoenig approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just the one suggestion

CHANGELOG.md Outdated Show resolved Hide resolved
@tgross tgross mentioned this pull request Jun 28, 2021
Closed
@tgross @shoenig
Update CHANGELOG.md
2efd1cb 
Co-authored-by: Seth Hoenig <shoenig@hashicorp.com>
@vercel vercel bot temporarily deployed to Preview – nomad June 28, 2021 19:51 Inactive
@tgross tgross merged commit 7edf0cc into main Jun 28, 2021
@tgross tgross deleted the docs-portmap-unset-to-field branch June 28, 2021 19:55
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@notnoop notnoop Awaiting requested review from notnoop

Assignees
No one assigned
Labels
theme/docs Documentation issues and enhancements theme/networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default behavior for port mapping
2 participants
@tgross @shoenig