Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: remove duplicate name check during validation #10868

Merged
merged 2 commits into from
Jul 8, 2021
Merged

service: remove duplicate name check during validation #10868

merged 2 commits into from
Jul 8, 2021

Commits on Jul 8, 2021

  1. service: remove duplicate name check during validation 

    When a task group with `service` block(s) is validated, we validate that there
are no duplicates, but this validation doesn't have access to the task environment
because it hasn't been created yet. Services and checks with interpolation can
be flagged incorrectly as conflicting. Name conflicts in services are not
actually an error in Consul and users have reported wanting to use the same
service name for task groups differentiated by tags.
    @tgross
    tgross committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d97baa5 View commit details
    Browse the repository at this point in the history

  2. Update .changelog/10868.txt 

    Co-authored-by: Seth Hoenig <shoenig@hashicorp.com>
    @tgross @shoenig
    tgross and shoenig committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e2af6f3 View commit details
    Browse the repository at this point in the history