Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: do not internalize constraint strings #10896

Merged
merged 4 commits into from
Jul 14, 2021
Merged

core: do not internalize constraint strings #10896

merged 4 commits into from
Jul 14, 2021

Commits on Jul 14, 2021

  1. core: do not memoize constraint strings 

    This PR causes Nomad to no longer memoize the String value of
a Constraint. The private memoized variable may or may not be
initialized at any given time, which means a reflect.DeepEqual
comparison between two jobs (e.g. during Plan) may return incorrect
results.

Fixes #10836
    @shoenig
    shoenig committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    07c57ff View commit details
    Browse the repository at this point in the history

  2. core: fix constraint tests

    @shoenig
    shoenig committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    755c5fa View commit details
    Browse the repository at this point in the history

  3. core: add spec changed test with constriants

    @shoenig
    shoenig committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    564be22 View commit details
    Browse the repository at this point in the history

  4. docs: add changelog entry

    @shoenig
    shoenig committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    2f2eef0 View commit details
    Browse the repository at this point in the history