Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul/connect: avoid warn messages on connect proxy errors #10951

Merged
merged 1 commit into from
Aug 6, 2021

Commits on Aug 5, 2021

  1. consul/connect: avoid warn messages on connect proxy errors

    When creating a TCP proxy bridge for Connect tasks, we are at the
    mercy of either end for managing the connection state. For long
    lived gRPC connections the proxy could reasonably expect to stay
    open until the context was cancelled. For the HTTP connections used
    by connect native tasks, we experience connection disconnects.
    The proxy gets recreated as needed on follow up requests, however
    we also emit a WARN log when the connection is broken. This PR
    lowers the WARN to a TRACE, because these disconnects are to be
    expected.
    
    Ideally we would be able to proxy at the HTTP layer, however Consul
    or the connect native task could be configured to expect mTLS, preventing
    Nomad from MiTM the requests.
    
    We also can't mange the proxy lifecycle more intelligently, because
    we have no control over the HTTP client or server and how they wish
    to manage connection state.
    
    What we have now works, it's just noisy.
    
    Fixes #10933
    jrasell committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    a946419 View commit details
    Browse the repository at this point in the history