Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider all system jobs for a new node #11054

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Consider all system jobs for a new node #11054

merged 4 commits into from
Aug 18, 2021

Commits on Aug 13, 2021

  1. add a failing test

    Mahmood Ali committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    b483be9 View commit details
    Browse the repository at this point in the history
  2. Consider all system jobs for a new node

    When a node becomes ready, create an eval for all system jobs across
    namespaces.
    
    The previous code uses `job.ID` to deduplicate evals, but that ignores
    the job namespace. Thus if there are multiple jobs in different
    namespaces sharing the same ID/Name, only one will be considered for
    running in the new node. Thus, Nomad may skip running some system jobs
    in that node.
    Mahmood Ali committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    f758323 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Use plain NamespacedID struct

    NamespacedID is never nil and is very light (two string fields) that
    isn't in the hot path. So it's safe to return and use the struct
    directly.
    
    Avoiding using pointers here avoids the risk of dereferencing a nil
    pointer.
    Mahmood Ali committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    aaa822d View commit details
    Browse the repository at this point in the history
  2. changelog

    Mahmood Ali committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    3a0d0db View commit details
    Browse the repository at this point in the history