Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Docker extra_hosts behaviour post v1.1.3 #11079

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Aug 24, 2021

#11056 highlighted an issue with using extra_hosts with Consul Connect in Nomad v1.1.3 that was introduced by #10823.

This PR documents this new behaviour and provides a workaround for using sidecar_task.config instead to set the desired extra_hosts.

Preview:

Docker driver docs
image

Nomad 1.0.9 and 1.1.3 upgrade docs:
image

Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One grammar suggestion, but no show stoppers.

website/content/docs/drivers/docker.mdx Outdated Show resolved Hide resolved
Co-authored-by: Derek Strickland <1111455+DerekStrickland@users.noreply.github.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants