Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply authZ for nomad Raft RPC layer #11089

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Apply authZ for nomad Raft RPC layer #11089

merged 3 commits into from
Oct 5, 2021

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Aug 26, 2021

When mTLS is enabled, only nomad servers of the region should access the Raft RPC layer. Clients and servers in other regions should only use the Nomad RPC endpoints.

Co-authored-by: Michael Schurter mschurter@hashicorp.com
Co-authored-by: Seth Hoenig shoenig@hashicorp.com

Fixes #11084

When mTLS is enabled, only nomad servers of the region should access the
Raft RPC layer. Clients and servers in other regions should only use the
Nomad RPC endpoints.

Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
Co-authored-by: Seth Hoenig <shoenig@hashicorp.com>
@notnoop notnoop self-assigned this Aug 26, 2021
.changelog/11084.txt Outdated Show resolved Hide resolved
Co-authored-by: Kent 'picat' Gruber <kent@hashicorp.com>
@vercel vercel bot temporarily deployed to Preview – nomad August 27, 2021 14:42 Inactive
notnoop pushed a commit that referenced this pull request Aug 30, 2021
This allows us to spin up e2e clusters with mTLS configured for all HashiCorp services, i.e. Nomad, Consul, and Vault. Used it for testing #11089 .

mTLS is disabled by default. I have not updated Windows provisioning scripts yet - Windows also lacks ACL support from before. I intend to follow up for them in another round.
@schmichael schmichael added this to the 1.2.0 milestone Oct 4, 2021
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited to generate ephemeral certs right in tests instead of relying on pre-generated certificates in git.

@notnoop notnoop merged commit 88ff7f4 into main Oct 5, 2021
@notnoop notnoop deleted the b-cve-2021-37218 branch October 5, 2021 12:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2021-37218 Nomad Raft RPC Privilege Escalation
3 participants