-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow configuration of Docker hostnames in bridge mode #11173
Merged
Merged
Commits on Sep 7, 2021
-
plugins/drivers: modify CreateNetwork to accept a req struct.
In order to have a hostname passed as a configuration param when creating an allocation network, the CreateNetwork func of the DriverNetworkManager interface needs to be updated. In order to minimize the disruption of future changes, rather than add another string func arg, the function now accepts a request struct. The struct has the hostname as a field.
Configuration menu - View commit details
-
Copy full SHA for ccc5a45 - Browse repository at this point
Copy the full SHA ccc5a45View commit details -
network: modify CreateNetwork impls for func signature change.
The in-tree implementations of DriverNetworkManager.CreateNetwork have been modified to account for the function signature change. In updating for the change, the enhancement of adding hostnames to network namespaces has also been added to the Docker driver, whilst the default Linux manager does not current impelement it. The allocrunner includes additional validation of the new parameter to ensure it is used in the correct situations.
Configuration menu - View commit details
-
Copy full SHA for 4d1eb64 - Browse repository at this point
Copy the full SHA 4d1eb64View commit details -
jobspec: add new network.hostname parameter.
Add a new hostname string parameter to the network block which allows operators to specify the hostname of the network namespace. Changing this causes a destructive update to the allocation and it is omitted if empty from API responses.
Configuration menu - View commit details
-
Copy full SHA for 0cf0219 - Browse repository at this point
Copy the full SHA 0cf0219View commit details -
Configuration menu - View commit details
-
Copy full SHA for 559edb1 - Browse repository at this point
Copy the full SHA 559edb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0373ae0 - Browse repository at this point
Copy the full SHA 0373ae0View commit details
Commits on Sep 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b3f68e9 - Browse repository at this point
Copy the full SHA b3f68e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62f1386 - Browse repository at this point
Copy the full SHA 62f1386View commit details
Commits on Sep 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1153d6a - Browse repository at this point
Copy the full SHA 1153d6aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.