Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuration of Docker hostnames in bridge mode #11173

Merged
merged 8 commits into from
Sep 16, 2021
Merged

Commits on Sep 7, 2021

  1. plugins/drivers: modify CreateNetwork to accept a req struct.

    In order to have a hostname passed as a configuration param when
    creating an allocation network, the CreateNetwork func of the
    DriverNetworkManager interface needs to be updated. In order to
    minimize the disruption of future changes, rather than add another
    string func arg, the function now accepts a request struct. The
    struct has the hostname as a field.
    jrasell committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    ccc5a45 View commit details
    Browse the repository at this point in the history
  2. network: modify CreateNetwork impls for func signature change.

    The in-tree implementations of DriverNetworkManager.CreateNetwork
    have been modified to account for the function signature change.
    In updating for the change, the enhancement of adding hostnames to
    network namespaces has also been added to the Docker driver, whilst
    the default Linux manager does not current impelement it.
    
    The allocrunner includes additional validation of the new parameter
    to ensure it is used in the correct situations.
    jrasell committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    4d1eb64 View commit details
    Browse the repository at this point in the history
  3. jobspec: add new network.hostname parameter.

    Add a new hostname string parameter to the network block which
    allows operators to specify the hostname of the network namespace.
    
    Changing this causes a destructive update to the allocation and it
    is omitted if empty from API responses.
    jrasell committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    0cf0219 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    559edb1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0373ae0 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Configuration menu
    Copy the full SHA
    b3f68e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62f1386 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Configuration menu
    Copy the full SHA
    1153d6a View commit details
    Browse the repository at this point in the history