Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor forceCollapsed logic to use hasClientStatus prop #11281

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

ChaiWithJai
Copy link
Contributor

No description provided.

@ChaiWithJai ChaiWithJai merged commit 7bb2478 into f-sysbatch-ui Oct 6, 2021
@ChaiWithJai ChaiWithJai deleted the f-final-changes branch October 6, 2021 23:52
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Ember Asset Size action

As of 452835d

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +22 B -13 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Ember Test Audit comparison

f-sysbatch-ui 452835d change
passes 1171 1168 -3
failures 3 4 +1
flaky 1 4 +3
duration 000ms 000ms -000ms

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on f-sysbatch-ui:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group

Ember Test Audit detected these flaky tests on 452835d:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant