Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: set CpuWeight in cgroup-v2 #11287

Merged
merged 2 commits into from
Oct 14, 2021
Merged

executor: set CpuWeight in cgroup-v2 #11287

merged 2 commits into from
Oct 14, 2021

Commits on Oct 7, 2021

  1. exec: set CpuWeight in cgroup-v2

    Cgroup-v2 uses `cpu.weight` property instead of cpu shares:
    https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.html#cpu-interface-files
    . And it uses a different range (i.e. `[1, 10000]`) from cpu.shares
    (i.e. `[2, 262144]`) to make things more interesting.
    
    Luckily, the libcontainer provides a helper function to perform the
    conversion
    [`ConvertCPUSharesToCgroupV2Value`](https://pkg.go.dev/github.com/opencontainers/runc@v1.0.2/libcontainer/cgroups#ConvertCPUSharesToCgroupV2Value).
    
    I have confirmed that docker/libcontainer performs the conversion as
    well in
    https://github.com/opencontainers/runc/blob/v1.0.2/libcontainer/specconv/spec_linux.go#L536-L541
    , and that CpuShares is ignored by libcontainer in
    https://github.com/opencontainers/runc/blob/v1.0.2/libcontainer/cgroups/fs2/cpu.go#L24-L29
    .
    Mahmood Ali committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    c517bfc View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Changelog

    Mahmood Ali committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    219687e View commit details
    Browse the repository at this point in the history