Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: add client name tooltip when displaying client ID in tables #11358

Merged
merged 2 commits into from
Oct 21, 2021
Merged

ui: add client name tooltip when displaying client ID in tables #11358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f599ce
ui: add client name tooltip when displaying client ID in tables
lgfa29 Oct 21, 2021
52bd540
changelog: add entry for #11358
lgfa29 Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/11358.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
ui: Display client name as a tooltip where the client ID is used
```
16 changes: 14 additions & 2 deletions ui/app/templates/components/allocation-row.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,23 @@
<span class="color-swatch {{this.allocation.clientStatus}}" /> {{this.allocation.clientStatus}}
</td>
{{#if (eq this.context "volume")}}
<td data-test-client><LinkTo @route="clients.client" @model={{this.allocation.node}}>{{this.allocation.node.shortId}}</LinkTo></td>
<td data-test-client>
<span class="tooltip multiline" aria-label="{{this.allocation.node.name}}">
<LinkTo @route="clients.client" @model={{this.allocation.node}}>
{{this.allocation.node.shortId}}
</LinkTo>
</span>
</td>
{{/if}}
{{#if (or (eq this.context "taskGroup") (eq this.context "job"))}}
<td data-test-job-version>{{this.allocation.jobVersion}}</td>
<td data-test-client><LinkTo @route="clients.client" @model={{this.allocation.node}}>{{this.allocation.node.shortId}}</LinkTo></td>
<td data-test-client>
<span class="tooltip multiline" aria-label="{{this.allocation.node.name}}">
<LinkTo @route="clients.client" @model={{this.allocation.node}}>
{{this.allocation.node.shortId}}
</LinkTo>
</span>
</td>
{{else if (or (eq this.context "node") (eq this.context "volume"))}}
<td>
{{#if (or this.allocation.job.isPending this.allocation.job.isReloading)}}
Expand Down
8 changes: 7 additions & 1 deletion ui/app/templates/components/plugin-allocation-row.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,13 @@
</span>
</td>

<td data-test-client><LinkTo @route="clients.client" @model={{this.allocation.node}}>{{this.allocation.node.shortId}}</LinkTo></td>
<td data-test-client>
<span class="tooltip multiline" aria-label="{{this.allocation.node.name}}">
<LinkTo @route="clients.client" @model={{this.allocation.node}}>
{{this.allocation.node.shortId}}
</LinkTo>
</span>
</td>
<td>
{{#if (or this.allocation.job.isPending this.allocation.job.isReloading)}}
...
Expand Down