Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: bump rejected plans from debug -> info #11416

Merged
merged 2 commits into from
Nov 3, 2021
Merged

core: bump rejected plans from debug -> info #11416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0813de8
core: bump rejected plans from debug -> info
schmichael Oct 31, 2021
4e3d66c
add `/s/port-plan-failure` redirect and link to in in plan reject log…
lgfa29 Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/11416.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
core: Elevated rejected node plan log lines to help diagnose #9506
```
9 changes: 8 additions & 1 deletion nomad/plan_apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,14 @@ func evaluatePlanPlacements(pool *EvaluatePool, snap *state.StateSnapshot, plan
if !fit {
// Log the reason why the node's allocations could not be made
if reason != "" {
logger.Debug("plan for node rejected", "node_id", nodeID, "reason", reason, "eval_id", plan.EvalID)
//TODO This was debug level and should return
//to debug level in the future. However until
//https://github.com/hashicorp/nomad/issues/9506
//is resolved this log line is the only way to
//monitor the disagreement between workers and
//the plan applier.
logger.Info("plan for node rejected, refer to https://www.nomadproject.io/s/port-plan-failure for more information",
"node_id", nodeID, "reason", reason, "eval_id", plan.EvalID)
}
// Set that this is a partial commit
partialCommit = true
Expand Down
8 changes: 8 additions & 0 deletions website/redirects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,14 @@ module.exports = [
permanent: true,
},

// /s/* redirects for useful links that need a stable URL but we may need to
// change its destination in the future.
{
source: '/s/port-plan-failure',
destination: 'https://github.com/hashicorp/nomad/issues/9506',
permanent: false,
},

// Spark guide links are all repointed to deprecated nomad-spark repo
{
source: '/guides/spark',
Expand Down