Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: set the deregistration eval priority to the job priority. #11426

Merged
merged 2 commits into from
Nov 5, 2021
Merged

rpc: set the deregistration eval priority to the job priority. #11426

merged 2 commits into from
Nov 5, 2021

Commits on Nov 2, 2021

  1. rpc: set the deregistration eval priority to the job priority. 

    Previously when creating an eval for job deregistration, the eval
priority was set to the default value irregardless of the job
priority. In situations where an operator would want to deregister
a high priority job so they could re-register; the evaluation may
get blocked for some time on a busy cluster because of the
deregsiter priority.

If a job had a lower than default priority and was deregistered,
the deregister eval would get a priority higher than that of the
job. If we attempted to register another job with a higher
priority than this, but still below the default, the deregister
would be actioned before the register.

Both situations described above seem incorrect and unexpected from
a user prespective.

This fix modifies to behaviour to set the deregister eval priority
to that of the job, if available. Otherwise the default value is
still used.
    @jrasell
    jrasell committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    e25c8a6 View commit details
    Browse the repository at this point in the history

  2. changelog: add entry for #11426

    @jrasell
    jrasell committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    8b0e476 View commit details
    Browse the repository at this point in the history