Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Breadcrumbs Service #11590

Merged
merged 27 commits into from
Jan 5, 2022
Merged

Refactor: Breadcrumbs Service #11590

merged 27 commits into from
Jan 5, 2022

Commits on Dec 21, 2021

  1. chore: edit mirage scenario to populate csi

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    b14991e View commit details
    Browse the repository at this point in the history

  2. feat: create bucket service to register, deregister and store breadcr… 

    …umbs
    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    67e6cec View commit details
    Browse the repository at this point in the history

  3. fix: delete state from routes and move to controllers and add renderl… 

    …ess component to templates
    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    dcc9aa1 View commit details
    Browse the repository at this point in the history

  4. fix: delete old breadcrumbs and replace with bucket

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    126c4df View commit details
    Browse the repository at this point in the history

  5. feat: create trigger component 

    Create Trigger Component and deprecate Breadcrumb-Utils pattern.
    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    b1002d6 View commit details
    Browse the repository at this point in the history

  6. fix: resolve parent on job still issue with alloc job async relationship

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    b996834 View commit details
    Browse the repository at this point in the history

  7. fix: handle case for async relationships

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    db9d62d View commit details
    Browse the repository at this point in the history

  8. chore: write tests for trigger component

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    972b52a View commit details
    Browse the repository at this point in the history

  9. test: breadcrumbs functionality

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    2cc8a37 View commit details
    Browse the repository at this point in the history

  10. refactor: remove double each in app breadcrumbs

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    210d0b3 View commit details
    Browse the repository at this point in the history

  11. refactor: delete app-breadcrumbs component file

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    4cadf69 View commit details
    Browse the repository at this point in the history

  12. refactor: delete unit tests for old breadcrumbs service

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0ea0e69 View commit details
    Browse the repository at this point in the history

  13. fix: update breadcrumb tests according to new breadcrumb structure

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    5ca9ebe View commit details
    Browse the repository at this point in the history

  14. fix: add in for topology route

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    fa5096a View commit details
    Browse the repository at this point in the history

  15. fix: delete jobs route - ember creates this for us

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    dd04270 View commit details
    Browse the repository at this point in the history

  16. update: add comment to explain loading namespaces in alloc route

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    7bf2880 View commit details
    Browse the repository at this point in the history

  17. feat: add title to default breadcrumb component

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0334709 View commit details
    Browse the repository at this point in the history

  18. style: add styling for title on breadcrumbs

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    a262979 View commit details
    Browse the repository at this point in the history

  19. refact: add title to breadcrumb generator 

    All breadcrumbs do not need a title property because some views
drill down by using a tab-based UI (e.g. CSI volumes and the Job Overview)

The goal is to help us identify breadcrumbs that are non-descriptive (i.e.
breadcrumbs that display as an ID).
    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e1a5760 View commit details
    Browse the repository at this point in the history

  20. feat: handle title behavior for job breadcrumb

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    10db60e View commit details
    Browse the repository at this point in the history

  21. style: centering and spacing for titled breadcrumbs

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    ed49d59 View commit details
    Browse the repository at this point in the history

  22. fix: test specs should expect to receive breadcrumb titles

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    1a2914b View commit details
    Browse the repository at this point in the history

  23. styling: fix opacity for last child in the list

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    92fafca View commit details
    Browse the repository at this point in the history

  24. fix: add ember-a11y-testing-audit-call

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    4d39d88 View commit details
    Browse the repository at this point in the history

  25. chore: clean-up merge conflict after rebase

    @ChaiWithJai
    ChaiWithJai committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    c1d2920 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. fix: remove unecessary breadcrumb

    @ChaiWithJai
    ChaiWithJai committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    b25f5ff View commit details
    Browse the repository at this point in the history

  2. refact: clean-up breadcrumb invocations

    @ChaiWithJai
    ChaiWithJai committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    3bdf661 View commit details
    Browse the repository at this point in the history