-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: authorization bug for job-client-status-summary
#11780
Conversation
Ember Asset Size actionAs of 8d8fe0b Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
There was previously a bug with sourceMaps that slowed down the build. This issue has been resolved by Ember and now we can expect the default behavior of sourceMaps being enabled in dev and disabled in prod.
…nd param-child to use Glimmer
Previously, the router service was not available to components. Now that it is, we no longer need to prop-drill this linking action.
f2df422
to
6c65966
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👏 - I have one small comment
@@ -217,3 +227,13 @@ module('Acceptance | job clients', function (hooks) { | |||
// TODO: add facet tests for actual list filtering | |||
} | |||
}); | |||
|
|||
function setPolicy(policy) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are repeating ourselves here, ui/tests/helpers/module-for-job.js
and ui/tests/acceptance/job-clients-test.js
are both defining this function - we should extract that into a test-utility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR handles an unexpected authorization failure when in a
system
orsysbatch
page withoutnode:read
permissions.This PR closes 11660.
This PR handles the concerns of 11672.