Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: detect and log unexpected scheduling collisions #11793

Merged
merged 29 commits into from
Jan 15, 2022
Merged

scheduler: detect and log unexpected scheduling collisions #11793

merged 29 commits into from
Jan 15, 2022

Commits on Jan 13, 2022

  1. initial work on port collision detection

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    67eaae6 View commit details
    Browse the repository at this point in the history

  2. pass copy on scheduler worker events and gc old entries

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    86f90e9 View commit details
    Browse the repository at this point in the history

  3. fix test for new network index methods signature

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    520febd View commit details
    Browse the repository at this point in the history

  4. add tests for new Copy() methods

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    8de0caf View commit details
    Browse the repository at this point in the history

  5. godoc for scheduler.Context EventsCh

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    1cfa5d8 View commit details
    Browse the repository at this point in the history

  6. log collision reason on AllocsFit

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    7383f08 View commit details
    Browse the repository at this point in the history

  7. fix SetNode collision check logic to match current implementation

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    edc529d View commit details
    Browse the repository at this point in the history

  8. exhaust node on port collision

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    318f93e View commit details
    Browse the repository at this point in the history

  9. fix NoopScheduler and NewEvalContext test

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    676b549 View commit details
    Browse the repository at this point in the history

  10. fix scheduler tests that had network port collisions

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    547eb10 View commit details
    Browse the repository at this point in the history

  11. fix test for agent command

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    2d0d7ea View commit details
    Browse the repository at this point in the history

  12. revert mock.Alloc to have reserved ports

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    84bfecf View commit details
    Browse the repository at this point in the history

  13. fix linter and broken test

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    ce2e15c View commit details
    Browse the repository at this point in the history

  14. rename EvalEvent -> PortCollisionEvent and add tests port collision d… 

    …uring binpack
    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    ec08415 View commit details
    Browse the repository at this point in the history

  15. use testutil.TestMultiplier for binpack iterator tests

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    a089c7a View commit details
    Browse the repository at this point in the history

  16. add logic to copy NodeNetworks when copying NodeResources

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    e1a57a6 View commit details
    Browse the repository at this point in the history

  17. address comments from code review

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    dbebd4f View commit details
    Browse the repository at this point in the history

  18. improve log message for unexpected node port collisions and dedent th… 

    …e event handler logic
    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    e9c72f0 View commit details
    Browse the repository at this point in the history

  19. re-order some Copy method to match the struct order and add nil checks

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    3f76756 View commit details
    Browse the repository at this point in the history

  20. small comment updates

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    60b8a1d View commit details
    Browse the repository at this point in the history

  21. remove failing tests

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    574102c View commit details
    Browse the repository at this point in the history

  22. can't Fatalf from goroutine

    @lgfa29
    lgfa29 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    56946d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. add nomad.plan.node_rejected metric

    @lgfa29
    lgfa29 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3c32065 View commit details
    Browse the repository at this point in the history

  2. set planner scheduler events channel

    @lgfa29
    lgfa29 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    60ccce4 View commit details
    Browse the repository at this point in the history

  3. refactor scheduler event interface

    @lgfa29
    lgfa29 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    b08a423 View commit details
    Browse the repository at this point in the history

  4. fix NetworkIndex Copy

    @lgfa29
    lgfa29 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    cbc1528 View commit details
    Browse the repository at this point in the history

  5. sanitize PortCollisionEvent at log time

    @lgfa29
    lgfa29 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    835b26b View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. use CopySkipJob when sanitizing PortCollisionEvent

    @lgfa29
    lgfa29 committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    fc0e144 View commit details
    Browse the repository at this point in the history

  2. fix linter

    @lgfa29
    lgfa29 committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    d2fdd01 View commit details
    Browse the repository at this point in the history