-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add links to legend items in allocation-summary
#11820
Merged
+173
−47
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
205a07c
feat: add clicking functionality to alloc status legend
ChaiWithJai 1eebec0
styling: update styling to match new figma mocks
ChaiWithJai c1bef17
fix: typo in data-test-selector
ChaiWithJai ecaf46c
refact: allocation and child summaries into ember-cli-page-object c…
ChaiWithJai 2e73e42
styling: remove clickable link text decoration override to match new…
ChaiWithJai a3d6240
refact: add data-test-selectors and correct css selectors in summary
ChaiWithJai 08a5e86
test: add test stories for clicking allocation summary
ChaiWithJai 9731dea
chore: add changelog
ChaiWithJai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:improvement | ||
ui: add links to legend items in allocation-summary | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 10 additions & 4 deletions
14
ui/app/templates/components/job-page/parts/summary-legend-item.hbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,18 @@ | ||
<div class="legend-item"> | ||
<span class="color-swatch {{if @datum.className @datum.className (concat "swatch-" @index)}}" /> | ||
<span | ||
class="color-swatch {{if @datum.className @datum.className (concat "swatch-" @index)}}" | ||
></span> | ||
<span class="text"> | ||
<span class="value" data-test-legend-value="{{@datum.className}}">{{@datum.value}}</span> | ||
<span class="label">{{@datum.label}}</span> | ||
<span class="value" data-test-legend-value="{{@datum.className}}"> | ||
{{@datum.value}} | ||
</span> | ||
<span> | ||
{{@datum.label}} | ||
</span> | ||
Comment on lines
-2
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Auto-formater strikes again 😄 I think this file didn't actually change? |
||
</span> | ||
{{#if @datum.help}} | ||
<span class="tooltip multiline" role="tooltip" aria-label="{{@datum.help}}"> | ||
{{x-icon "info-circle-outline" class="is-faded"}} | ||
</span> | ||
{{/if}} | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can remove this rule now? The background colour change on hover may not be necessary anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought:
Let's wait on styling and UX changes until the Nomad Design Refresh slated for
2.0
. Otherwise, we'll go back and forth on changes for a long time when I can prioritize other higher value activities in the meantime. Also... we don't have visual regression testing in place, I'd rather focus on getting that up prior to making changes so we don't get blindsided by changes.