-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IsEmpty logic in finalizeClientTemplateConfig #11930
Conversation
08c40c2
to
560ffca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm going to nitpick the commit title though... aren't we adding more logic to the IsEmpty()
method?
560ffca
to
ad57527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
When parsing the new
consul-template
configuration parameters introduced in 1.2.4 , thefinalizeClientTemplateConfig
function failed to account for the pre-1.2.4 fields in its logic and set theClientTemplateConfig
tonil
only if none of the new configuration options were set.This PR:
consul-template
settings introduced in 1.2.4 can still parse.Closes #11902