Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gopsutil to 3.21.12 #11955

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Update gopsutil to 3.21.12 #11955

merged 3 commits into from
Feb 15, 2022

Conversation

angrycub
Copy link
Contributor

Resolves a buildtime warning about deprecations in IOKitLib on macOS 12

# github.com/shirou/gopsutil/v3/disk
iostat_darwin.c:28:2: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:132:1: note: 'IOMasterPort' has been explicitly marked deprecated here
# github.com/shirou/gopsutil/v3/host
smc_darwin.c:75:41: warning: 'kIOMasterPortDefault' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:123:19: note: 'kIOMasterPortDefault' has been explicitly marked deprecated here

@angrycub angrycub added type/enhancement theme/dependencies Pull requests that update a dependency file labels Jan 27, 2022
@vercel vercel bot temporarily deployed to Preview – nomad January 27, 2022 19:11 Inactive
shoenig
shoenig approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lgfa29 added a commit to ttys3/nomad that referenced this pull request Feb 5, 2022
@lgfa29
changelog: add entry for hashicorp#11955
c8f0cc4
@tgross
Copy link
Member

tgross commented Feb 7, 2022

@angrycub any reason we shouldn't merge this at this point?

@angrycub
Copy link
Contributor Author

angrycub commented Feb 7, 2022

From a review of the changes in the gopsutil release notes, I couldn't see a reason to not merge now.

@tgross
Copy link
Member

tgross commented Feb 7, 2022

Oh this might have user-facing impact. Let's add a changelog too!

@vercel vercel bot temporarily deployed to Preview – nomad February 10, 2022 00:31 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 15, 2022 14:31 Inactive
@shoenig
Copy link
Member

shoenig commented Feb 15, 2022 •
edited

I shortened the CL to fit on one line

@shoenig shoenig merged commit 53577ea into main Feb 15, 2022
@shoenig shoenig deleted the f-update-gopsutil branch February 15, 2022 14:31
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
theme/dependencies Pull requests that update a dependency file type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@angrycub @tgross @shoenig