e2e: account for new job stop CLI exit behaviour. #11968
Conversation
PR #11550 changed the job stop exit behaviour when monitoring the deployment. When stopping a job, the deployment becomes cancelled and therefore the CLI now exits with status code 1 as it see this as an error. This change adds a new utility e2e function that accounts for this behaviour.
There was a problem hiding this comment.
LGTM! I like the approach you're taking here.
That being said, I'm not sure we shouldn't fix this by changing the exit code on nomad job stop so that it's not picking up that deployment cancel as an error. But I think it's more important to get E2E working first and then we can come back and fix that later.
yeah completely agree; i'll get this fix in and then raise a follow up to look into the plan exit code. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
PR #11550 changed the job stop exit behaviour when monitoring the
deployment. When stopping a job, the deployment becomes cancelled
and therefore the CLI now exits with status code 1 as it see this
as an error.
This change adds a new utility e2e function that accounts for this
behaviour.
Closes #11950