Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: bootstrap envoy using -proxy-id #12011

Merged
merged 1 commit into from
Feb 18, 2022
Merged

connect: bootstrap envoy using -proxy-id #12011

merged 1 commit into from
Feb 18, 2022

Commits on Feb 18, 2022

  1. connect: bootstrap envoy using -proxy-id

    This PR modifies the Consul CLI arguments used to bootstrap envoy for
    Connect sidecars to make use of '-proxy-id' instead of '-sidecar-for'.
    
    Nomad registers the sidecar service, so we know what ID it has. The
    '-sidecar-for' was intended for use when you only know the name of the
    service for which the sidecar is being created.
    
    The improvement here is that using '-proxy-id' does not require an underlying
    request for listing Consul services. This will make make the interaction
    between Nomad and Consul more efficient.
    
    Closes #10452
    shoenig committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    efee15f View commit details
    Browse the repository at this point in the history