Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs and changelog for nomad config validate #12031

Merged
merged 2 commits into from
Feb 9, 2022
Merged

docs and changelog for nomad config validate #12031

merged 2 commits into from
Feb 9, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Feb 8, 2022

For #9198

jrasell
jrasell requested changes Feb 9, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry seems incorrect and a link tag (or whatever its proper name is) needs to be update, other than that looks good.

.changelog/9198.txt Outdated Show resolved Hide resolved
website/content/docs/commands/config/index.mdx Outdated Show resolved Hide resolved
jrasell
jrasell approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross merged commit b3212a5 into main Feb 9, 2022
@tgross tgross deleted the docs-config-validate branch February 9, 2022 15:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

@DerekStrickland DerekStrickland Awaiting requested review from DerekStrickland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgross @jrasell