Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: make gRPC client creation more robust #12057

Merged
merged 6 commits into from
Feb 15, 2022
Merged

Commits on Feb 11, 2022

  1. Configuration menu
    Copy the full SHA
    787acdf View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. csi: refactor gRPC client to connect on first use

    The gRPC client for CSI connected to the socket during initialization
    so that we can ensure the gRPC service interfaces have been
    initialized before use. But this design makes it challenging to
    correctly retry and timeout the initial connection in the plugin
    supervisor and then reuse that same client for fingerprinting.
    
    Lazily connect to the socket on the first RPC call, allowing the
    caller's context to be used to control retries and timeouts.
    
    This also gives the CSI plugin manager instance the ability to retry
    its initial connection setup.
    tgross committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    e898121 View commit details
    Browse the repository at this point in the history
  2. csi: reuse gRPC client in plugin supervisor hook

    The plugin supervisor hook creates a new gRPC client for every probe
    and then throws it away. Instead, reuse the client as we do for the
    plugin manager.
    tgross committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    c2b7dda View commit details
    Browse the repository at this point in the history
  3. csi: exit plugin supervisor after 30s without initial connection

    The plugin supervisor registers the plugin in the `Poststart` hook, so
    the task itself should be running. If the plugin can't communicate
    with us after 30s, exit and mark the task as unhealthy so that it can
    be restarted.
    tgross committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    a42c1cf View commit details
    Browse the repository at this point in the history
  4. changelog entry

    tgross committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    4804d2f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dfadb2b View commit details
    Browse the repository at this point in the history