Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI: enforce usage at claim time #12112

Merged
merged 4 commits into from
Feb 24, 2022
Merged

CSI: enforce usage at claim time #12112

merged 4 commits into from
Feb 24, 2022

Commits on Feb 23, 2022

  1. csi: remove redundant schedulable check in FreeWriteClaims 

    If a volume has been created but not yet claimed, its capabilities
will be checked in `WriteSchedulable` at both scheduling time and
claim time. We don't need to also check them in the `FreeWriteClaims`
method.
    @tgross
    tgross committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    3aedd9b View commit details
    Browse the repository at this point in the history

  2. csi: running allocations for the same job should block claims 

    When the scheduler checks feasibility for CSI volumes, the check is
fairly loose: earlier versions of the same job are not counted as
active claims. This allows the scheduler to place new allocations
for the new version of a job, under the assumption that we'll replace
the existing allocations and their volume claims.

But when the alloc runner claims the volume, we need to enforce the
active claims even if they're for allocations of an earlier version of
the job. Otherwise we'll try to mount a volume that's currently being
unmounted, and this will cause replacement allocations to frequently
fail.

This commit correctly enforces maximum volume claims for writers.
    @tgross
    tgross committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    3128710 View commit details
    Browse the repository at this point in the history

  3. csi: enforce single-node reader check for read-only volumes 

    When the alloc runner makes a claim for a read-only volume, we only
check that the volume is potentially schedulable and not that it
actually has free read claims.
    @tgross
    tgross committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    85c086e View commit details
    Browse the repository at this point in the history

  4. changelog entry

    @tgross
    tgross committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    7200e88 View commit details
    Browse the repository at this point in the history