Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of chore: bump docs-page for code-block fix into stable-website #12127

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #12117 to be assessed for backporting due to the inclusion of the label backport/website.

The below text is copied from the body of the original PR.


👀 Preview

This PR bumps to the latest @hashicorp/react-docs-page release, in order to fix an underlying issue in @hashicorp/react-code-block (via @hashicorp/platform-docs-mdx).

This fix is specific to Firefox browsers, and with this fix, newlines are now included when manually selecting and copying code-block contents.

See hashicorp/react-components#503 for further details.

Review notes

When using Firefox:

  • On the live site, manually selecting code block contents, copying, and pasting into a plain text editor should result in missing newlines.
  • On the preview, manually selecting code block contents, copying, and pasting into a plain text editor should result in the expected content, with newlines intact.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants