-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disconnected clients: Add reconnect task event #12133
disconnected clients: Add reconnect task event #12133
Conversation
7074c56
to
669f113
Compare
669f113
to
5a01e9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up question in thread
Log as error not trace
* Add TaskClientReconnectedEvent constant * Add allocRunner.Reconnect function to manage task state manually * Removes server-side push
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR introduces a new
TaskClientReconnected
task event. This task event will be appended by theallocRunner
each time an unknown alloc is reconnected after theclient
comes back online.This PR includes:
TaskEvent
and translating it to meaningful human text for display.client
and into theallocRunner
as it has grown in scope. Specifically, the logic workflow is now:client
.clientAlloc
to compute the current alloc state including the appended events.client
state store with the updated alloc. Exits if this fails.client
alloc state to the server.Plan
as they will be pulled by the node when it reconnects.