disconnected clients: Observability plumbing #12141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekStrickland
changed the title
tgross
approved these changes
Mar 1, 2022
Comment on lines
+148
to
+149
| base := fmt.Sprintf("Total changes: (place %d) (destructive %d) (inplace %d) (stop %d) (disconnect %d) (reconnect %d)", | ||
| len(r.place), len(r.destructiveUpdate), len(r.inplaceUpdate), len(r.stop), len(r.disconnectUpdates), len(r.reconnectUpdates)) |
There was a problem hiding this comment.
Possibly nitpicky: because this report is for "Total changes", is calling the change disconnect and reconnect the right name? That reads to me like the scheduler is asking for the allocs to be disconnected or reconnected. (Might be a good question to throw to the team for bikeshedding 😀 )
DerekStrickland
added a commit
that referenced
this pull request
Apr 5, 2022
* Add disconnects/reconnect to log output and emit reschedule metrics * TaskGroupSummary: Add Unknown, update StateStore logic, add to metrics
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE TO REVIEWER: Converting this back to draft, as it makes sense to include the
TaskGroupSummarychanges in this batch of commits.This PR contains three changes.
disconnect&reconnectto theGoStringimplementation forreconcileResultsso that the count of thesemaps will be included in log output.
emitRescheduleInfoincreateTimeoutLaterEvalsso that metrics will now include reschedule metrics for disconnects.Unknownfield to theTaskGroupSummarystruct and includes that value in all related processing and metrics.