-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disconnected clients: Observability plumbing #12141
disconnected clients: Observability plumbing #12141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
base := fmt.Sprintf("Total changes: (place %d) (destructive %d) (inplace %d) (stop %d) (disconnect %d) (reconnect %d)", | ||
len(r.place), len(r.destructiveUpdate), len(r.inplaceUpdate), len(r.stop), len(r.disconnectUpdates), len(r.reconnectUpdates)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly nitpicky: because this report is for "Total changes", is calling the change disconnect
and reconnect
the right name? That reads to me like the scheduler is asking for the allocs to be disconnected or reconnected. (Might be a good question to throw to the team for bikeshedding 😀 )
* Add disconnects/reconnect to log output and emit reschedule metrics * TaskGroupSummary: Add Unknown, update StateStore logic, add to metrics
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
NOTE TO REVIEWER: Converting this back to draft, as it makes sense to include the
TaskGroupSummary
changes in this batch of commits.This PR contains three changes.
disconnect
&reconnect
to theGoString
implementation forreconcileResults
so that the count of thesemaps will be included in log output.
emitRescheduleInfo
increateTimeoutLaterEvals
so that metrics will now include reschedule metrics for disconnects.Unknown
field to theTaskGroupSummary
struct and includes that value in all related processing and metrics.