Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI: allow updates to volumes on re-registration #12167

Merged
merged 5 commits into from
Mar 7, 2022
Merged

CSI: allow updates to volumes on re-registration #12167

merged 5 commits into from
Mar 7, 2022

Commits on Mar 3, 2022

  1. csi: rename state store volume upsert method 

    Clarify that this state store method is used for everything, not just
for the `Register` RPC.
    @tgross
    tgross committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    dcdb4f6 View commit details
    Browse the repository at this point in the history

  2. csi: factor out a method for topology fit

    @tgross
    tgross committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    f730a28 View commit details
    Browse the repository at this point in the history

  3. csi: allow updates to volumes on re-registration 

    CSI `CreateVolume` RPC is idempotent given that the topology,
capabilities, and parameters are unchanged. CSI volumes have many
user-defined fields that are immutable once set, and many fields that
are not user-settable.

Update the `Register` RPC so that updating a volume via the API merges
onto any existing volume without touching Nomad-controlled fields,
while validating it with the same strict requirements expected for
idempotent `CreateVolume` RPCs.
    @tgross
    tgross committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    2c23e25 View commit details
    Browse the repository at this point in the history

  4. changelog entry

    @tgross
    tgross committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    95c8ce8 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. make topo requests immutable once topo is set

    @tgross
    tgross committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    e6146f6 View commit details
    Browse the repository at this point in the history