Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service discovery: add HTTP endpoints and sdk wrapper #12172

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Mar 2, 2022

This work continues to build out the service discovery feature by adding the HTTP and Go SDK covering all the publicly available RPC endpoints. This includes a new endpoint as well as updates to the alloc and job endpoints to provide easy lookup of registrations associated to these objects.

The PR is split into commits which group the additions into logical chunks and hope to make it easier to review.

closes https://github.com/hashicorp/team-nomad/issues/262

@jrasell jrasell added this to the 1.3.0 milestone Mar 2, 2022
@jrasell jrasell requested a review from schmichael March 2, 2022 11:48
@jrasell jrasell self-assigned this Mar 2, 2022
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did have one question about the shape of the response we're returning from List but I could just be missing something.

api/service_registrations.go Outdated Show resolved Hide resolved
api/service_registrations.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad March 3, 2022 11:14 Inactive
Base automatically changed from f-gh-259 to f-1.3-boogie-nights March 4, 2022 08:25
@jrasell jrasell merged commit b10547d into f-1.3-boogie-nights Mar 4, 2022
@jrasell jrasell deleted the f-gh-262 branch March 4, 2022 08:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants