-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaxClientDisconnect
Jobspec checklist
#12177
MaxClientDisconnect
Jobspec checklist
#12177
Conversation
9502d8a
to
20e2a22
Compare
20e2a22
to
a5bf09f
Compare
a5bf09f
to
015ca91
Compare
MaxClientDisconnect
Jobspec checklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've left some small suggestions but once those are resolved it should be good-to-merge
if tg.MaxClientDisconnect == nil { | ||
oldPrimitiveFlat["MaxClientDisconnect"] = "" | ||
} else { | ||
oldPrimitiveFlat["MaxClientDisconnect"] = fmt.Sprintf("%d", *tg.MaxClientDisconnect) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This the first time I really noticed what we're doing to these duration fields in Diff and it's kinda weird to squash them down into ints, right? But definitely the right thing to match the behavior of the other fields. 🤷
* api: Add struct, conversion function, and tests * TaskGroup: Add field, validation, and tests * diff: Add diff handler and test * docs: Update docs
* api: Add struct, conversion function, and tests * TaskGroup: Add field, validation, and tests * diff: Add diff handler and test * docs: Update docs
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
max_client_disconnect
Jobspec ChecklistCode
api/
packageCopy
MethodCanonicalize
nomad/structs
package - NOTE: That field was added in a previous PRstructs/
structs usually have Copy,Equals, and Validate methodsapi/
packageapi/
andnomad/structs/
incommand/agent/job_endpoint.go
nomad/structs/diff.go
scheduler/util.go/tasksUpdated
Docs