-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add native service discovery admin boolean parameter. #12190
Conversation
command/agent/config.go
Outdated
// enable/disable to Nomad native service discovery feature on the client. | ||
// This parameter is exposed via the Nomad fingerprinter and used to ensure | ||
// correct scheduling decisions on allocations which require this. | ||
NativeServiceDiscovery *bool `hcl:"native_service_discovery"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I guess this is our last chance to bikeshed so I'll bite:
Should we call this this NomadServiceDiscovery
/ nomad_service_discovery
?
I know having a self-referential configuration name is weird, but if we ever added an option to disable the Consul provider it would have slightly nicer symmetry: {nomad,consul}_service_discovery = {true,false}
Feel free to ignore... just thought I'd put thoughts down in case anybody has strong feelings one way or the other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense and lines up more with the fingerprint value. The self reference is a little odd, but in the larger context as you mention it sounds reasonable.
This only targets the feature branch, so we can always change it if we want again before release.
command/agent/config.go
Outdated
@@ -966,6 +973,7 @@ func DefaultConfig() *Config { | |||
BindWildcardDefaultHostNetwork: true, | |||
CNIPath: "/opt/cni/bin", | |||
CNIConfigDir: "/opt/cni/config", | |||
NativeServiceDiscovery: helper.BoolToPtr(true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
ab21a49
to
9215d0c
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This adds a boolean configuration parameter giving operators the ability to enable/disable clients from utilising the Nomad native service discovery feature.
closes https://github.com/hashicorp/team-nomad/issues/261