Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service discovery: add config boolean parameter and fingerprinting #12201

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Mar 7, 2022

This change adds a new client parameter which allows operators to control whether the client can utilise the native service discovery feature. This will default to true, meaning the feature is enabled. This configuration value is exported as a fingerprinted attribute under the meta partition.

In order to ensure allocations are only placed on clients which have the feature enabled, when using provider = nomad the job group is mutated to contain a constraint. This mutator mimics the current Vault mutator.

closes https://github.com/hashicorp/team-nomad/issues/265

@jrasell jrasell added this to the 1.3.0 milestone Mar 7, 2022
@jrasell jrasell requested a review from schmichael March 7, 2022 08:57
@jrasell jrasell self-assigned this Mar 7, 2022
nomad/job_endpoint_hooks.go Outdated Show resolved Hide resolved
nomad/structs/job.go Outdated Show resolved Hide resolved
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview – nomad March 14, 2022 11:42 Inactive
Base automatically changed from f-gh-261 to f-1.3-boogie-nights March 14, 2022 12:19
@jrasell jrasell merged commit 066747c into f-1.3-boogie-nights Mar 14, 2022
@jrasell jrasell deleted the f-gh-265 branch March 14, 2022 12:28
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants