Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about docker DNS config when using bridge mode #12229

Merged
merged 1 commit into from
Mar 8, 2022
Merged

docs: add note about docker DNS config when using bridge mode #12229

merged 1 commit into from
Mar 8, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 8, 2022 •
edited
Loading

Fixes #11857 #11239

The Docker DNS configuration options are not compatible with a
group-level network in bridge mode. Warn users about this in the
Docker task configuration docs.

@tgross tgross added theme/docs Documentation issues and enhancements backport/1.0.16 labels Mar 8, 2022
@tgross tgross mentioned this pull request Mar 8, 2022
Open
shoenig
shoenig approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

website/content/docs/drivers/docker.mdx Outdated Show resolved Hide resolved
@tgross
docs: add note about docker DNS config when using bridge mode
3955c33 
The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
@tgross tgross merged commit a9d64b8 into main Mar 8, 2022
@tgross tgross deleted the docs-docker-dns-options branch March 8, 2022 16:59
This was referenced Mar 8, 2022
Merged
Merged
Merged
This was referenced Mar 8, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
tgross pushed a commit that referenced this pull request Mar 8, 2022
@tgross
docs: add note about docker DNS config when using bridge mode (#12229)
010de86 
The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
tgross pushed a commit that referenced this pull request Mar 8, 2022
@tgross
docs: add note about docker DNS config when using bridge mode (#12229)
09b5b38 
The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
tgross pushed a commit that referenced this pull request Mar 8, 2022
@tgross
docs: add note about docker DNS config when using bridge mode (#12229)
f323054 
The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
tgross added a commit that referenced this pull request Mar 8, 2022
@tgross
docs: add note about docker DNS config when using bridge mode (#12229)
97375dd 
The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
tgross pushed a commit that referenced this pull request Mar 8, 2022
@tgross
docs: add note about docker DNS config when using bridge mode (#12229)
63eeb81 
The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
tgross pushed a commit that referenced this pull request Mar 8, 2022
@tgross
docs: add note about docker DNS config when using bridge mode (#12229)
deb834a 
The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
tgross pushed a commit that referenced this pull request Mar 8, 2022
@hc-github-team-nomad-core
docs: add note about docker DNS config when using bridge mode (#12229) (
ab9f851 
#12238)

The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
tgross pushed a commit that referenced this pull request Mar 8, 2022
@hc-github-team-nomad-core
docs: add note about docker DNS config when using bridge mode (#12229) (
65d944e 
#12234)

The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
tgross pushed a commit that referenced this pull request Mar 8, 2022
@hc-github-team-nomad-core
docs: add note about docker DNS config when using bridge mode (#12229) (
9d48e1c 
#12241)

The Docker DNS configuration options are not compatible with a
group-level network in `bridge` mode. Warn users about this in the
Docker task configuration docs.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@DerekStrickland DerekStrickland Awaiting requested review from DerekStrickland

Assignees
No one assigned
Labels
theme/docs Documentation issues and enhancements
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conflicting options: dns and the network mode (bridge)
2 participants
@tgross @shoenig