Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CSI volume list test #12245

Merged
merged 1 commit into from
Mar 9, 2022
Merged

fix CSI volume list test #12245

merged 1 commit into from
Mar 9, 2022

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Mar 9, 2022

#12167 renamed CSIVolumeRegister but I forgot to pull that change before merging #12186

@tgross tgross mentioned this pull request Mar 9, 2022
Closed
tgross
tgross approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Dupe of #12247 so I'll let you and @jrasell battle it out who gets to merge first 😀

@jrasell
Copy link
Member

jrasell commented Mar 9, 2022

LGTM. Dupe of #12247 so I'll let you and @jrasell battle it out who gets to merge first 😀

Oh damn; I should have checked! I'll close mine out seeing as this came before.

@tgross tgross merged commit 68b203f into main Mar 9, 2022
@tgross tgross deleted the fix-csi-volume-filter-test branch March 9, 2022 14:40
@tgross
Copy link
Member

tgross commented Mar 9, 2022

Merged this so I could rebase on main for #12249

@lgfa29 lgfa29 mentioned this pull request Mar 11, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lgfa29 @jrasell @tgross