Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add namespace param to job parse API #12258

Merged
merged 1 commit into from
Mar 10, 2022
Merged

docs: add namespace param to job parse API #12258

merged 1 commit into from
Mar 10, 2022

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Mar 10, 2022

#12038 added ACL requirements to the job parse endpoint to prevent potential abuse via malformed jobs.

Since job ACLs are attached to namespaces, and the token is checked before the job data is parsed to avoid abuse, the request must contain a namespace query param that the token is allowed to access.

@lgfa29 lgfa29 added the theme/docs Documentation issues and enhancements label Mar 10, 2022
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgfa29 lgfa29 merged commit 4a21dbc into main Mar 10, 2022
@lgfa29 lgfa29 deleted the docs-job-parse-ns branch March 10, 2022 21:35
@lgfa29 lgfa29 added the backport/website This will backport PR changes to `stable-website` && the latest release-branch label Mar 10, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/website This will backport PR changes to `stable-website` && the latest release-branch theme/docs Documentation issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants