Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Add unknown to TaskGroupSummary #12269

Merged
merged 1 commit into from
Mar 14, 2022
Merged

cli: Add unknown to TaskGroupSummary #12269

merged 1 commit into from
Mar 14, 2022

Conversation

DerekStrickland
Copy link
Contributor

@DerekStrickland DerekStrickland commented Mar 12, 2022 •
edited

This PR adds the Unknown field to the api.TaskGroupSummary struct and displays that field in the job status output.

@DerekStrickland DerekStrickland self-assigned this Mar 12, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@DerekStrickland DerekStrickland added this to the 1.3.0 milestone Mar 12, 2022
@DerekStrickland DerekStrickland marked this pull request as ready for review March 12, 2022 12:38
tgross
tgross approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DerekStrickland DerekStrickland merged commit 13e14ac into f-disconnected-client-allocation-handling Mar 14, 2022
@DerekStrickland DerekStrickland deleted the f-task-group-summary-disconnected-clients branch March 14, 2022 16:39
DerekStrickland added a commit that referenced this pull request Apr 5, 2022
@DerekStrickland
Add unknown to TaskGroupSummary (#12269)
b317aaa
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees

@DerekStrickland DerekStrickland

Labels
theme/edge
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DerekStrickland @hashicorp-cla @tgross