Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for allocs stopped due to reconnect #12270

Conversation

DerekStrickland
Copy link
Contributor

@DerekStrickland DerekStrickland commented Mar 12, 2022

When assessing the event stream for disconnected client events, I found that allocations that are stopped due to a reconnect had a description indicating the alloc was stopped because the jobspec had changed, which is inaccurate. This PR adds a description so that the stop reason is accurate when an allocation is stopped due to a reconnect event.

@DerekStrickland DerekStrickland added this to the 1.3.0 milestone Mar 12, 2022
@DerekStrickland DerekStrickland self-assigned this Mar 12, 2022
@DerekStrickland DerekStrickland marked this pull request as ready for review March 12, 2022 16:16
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fit-and-finish stuff.

@DerekStrickland DerekStrickland merged commit f03749d into f-disconnected-client-allocation-handling Mar 14, 2022
@DerekStrickland DerekStrickland deleted the f-event-stream-disconnected-clients branch March 14, 2022 16:41
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants