Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comments: update some stale comments referencing deprecated config name #12271

Merged
merged 3 commits into from
Mar 14, 2022
Merged

comments: update some stale comments referencing deprecated config name #12271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
746e585
comments: update some stale comments referencing deprecated config name
Mar 14, 2022
6713219
Finish fixing the rename
DerekStrickland Mar 14, 2022
82715ed
Finish fixing rename
DerekStrickland Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nomad/structs/structs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10518,7 +10518,7 @@ type Evaluation struct {

// WaitUntil is the time when this eval should be run. This is used to
// supported delayed rescheduling of failed allocations, and delayed
// stopping of allocations that are configured with resume_after_client_reconnect.
// stopping of allocations that are configured with max_client_disconnect.
WaitUntil time.Time

// NextEval is the evaluation ID for the eval created to do a followup.
Expand Down
2 changes: 1 addition & 1 deletion scheduler/reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ func (a *allocReconciler) computeGroup(groupName string, all allocSet) bool {
lostLater := lost.delayByStopAfterClientDisconnect()
lostLaterEvals := a.createLostLaterEvals(lostLater, all, tg.Name)

// Find delays for any disconnecting allocs that have resume_after_client_reconnect,
// Find delays for any disconnecting allocs that have max_client_disconnect,
// create followup evals, and update the ClientStatus to unknown.
timeoutLaterEvals := a.createTimeoutLaterEvals(disconnecting, tg.Name)
// Merge disconnecting with the stop_after_client_disconnect set into the
Expand Down