Commits on Mar 29, 2022

1. template: disallow writeToFile by default …

   Resolves #12095 by WONTFIXing it.
   
   This approach disables `writeToFile` as it allows arbitrary host
   filesystem writes and is only a small quality of life improvement over
   multiple `template` stanzas.
   
   This approach has the significant downside of leaving people who have
   altered their `template.function_denylist` *still vulnerable!* I added
   an upgrade note, but we should have implemented the denylist as a
   `map[string]bool` so that new funcs could be denied without overriding
   custom configurations.
   
   This PR also includes a bug fix that broke enabling all consul-template
   funcs. We repeatedly failed to differentiate between a nil (unset)
   denylist and an empty (allow all) one.

   

   schmichael committed Mar 29, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for f87ec7e
   • Browse repository at this point

   Copy the full SHA

   f87ec7e View commit details

   Browse the repository at this point in the history

2. template: fix comments and docs …

   Review notes from @lgfa29
   
   Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>

   

   schmichael and lgfa29 committed Mar 29, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 3ca38ee
   • Browse repository at this point

   Copy the full SHA

   3ca38ee View commit details

   Browse the repository at this point in the history