client: hookup service wrapper for use in clients #12329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
approved these changes
Mar 21, 2022
| // TestGroupServiceHook_GroupServices_Nomad asserts group service hooks with | ||
| // group services does not error when using the Nomad provider. | ||
| func TestGroupServiceHook_GroupServices_Nomad(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
Suggested change
| t.Parallel() | |
| ci.Parallel(t) |
These should get caught by Semgrep if you rebase with main
| // Test_serviceHook_Nomad performs a normal operation test of the serviceHook | ||
| // when using task services which utilise the Nomad provider. | ||
| func Test_serviceHook_Nomad(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
Suggested change
| t.Parallel() | |
| ci.Parallle(t) |
Discussed internally; will rebase the feature branch shortly and address the changes needed. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the client task and alloc runners to utilise the new service registration wrapper. The service hooks have also been updated to use the wrapper along with some naming improvements which were previously Consul specific.
In order to handle a test case, the wrapper has been slightly modified. The function has a comment which details this change. Additional testing via table driven test should be added in the future.
closes https://github.com/hashicorp/team-nomad/issues/266