Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add service commands for list, info, and delete. #12330

Merged
merged 1 commit into from
Mar 23, 2022
Merged

cli: add service commands for list, info, and delete. #12330

merged 1 commit into from
Mar 23, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Mar 21, 2022

@jrasell jrasell added this to the 1.3.0 milestone Mar 21, 2022
@jrasell jrasell self-assigned this Mar 21, 2022
@vercel vercel bot temporarily deployed to Preview – nomad March 21, 2022 10:59 Inactive
Base automatically changed from f-gh-266-touchdown to f-1.3-boogie-nights March 22, 2022 09:42
@jrasell jrasell requested a review from shoenig March 22, 2022 16:53
shoenig
shoenig approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the passing thought on whether we'd ever need name+id to identify a service registration.

command/service_info.go Show resolved Hide resolved
command/service_delete.go Show resolved Hide resolved
@jrasell jrasell merged commit bd377c9 into f-1.3-boogie-nights Mar 23, 2022
@jrasell jrasell deleted the f-gh-263 branch March 23, 2022 14:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

@jazzyfresh jazzyfresh Awaiting requested review from jazzyfresh

Assignees

@jrasell jrasell

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrasell @shoenig