Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc and http2 listeners to gateway docs #12367

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Conversation

Dgotlieb
Copy link
Contributor

Stating at Nomad version 1.2.0 grpc and http2 protocols are supported

The change affects gateway protocol docs

Stating at Nomad version 1.2.0 `grpc` and `http2` [protocols are supported](hashicorp#11187):
…teners

Add grpc and http2 to gateway listeners
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 24, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks @Dgotlieb!

@Dgotlieb
Copy link
Contributor Author

Dgotlieb commented Mar 26, 2022

Thank you @lgfa29! I think at the same time we can also fix the sentence:

Note: If using http, preconfiguring a service-default in Consul to set the Protocol of the service to http is recommended.

To:

Note: If using http any non-tcp protocol, preconfiguring a service-default in Consul to set the Protocol of the service to the http desired protocol is recommended mandatory due to an open issue.

LMK if it seems correct and I will create a PR..

Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/website This will backport PR changes to `stable-website` && the latest release-branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants