Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cleanhttp.DefaultPooledTransport for the default API client #12409

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Use cleanhttp.DefaultPooledTransport for the default API client #12409

merged 2 commits into from
Apr 6, 2022

Commits on Apr 6, 2022

  1. Use cleanhttp.DefaultPooledTransport 

    The only difference is DefaultTransport sets DisableKeepAlives

This doesn't make much sense to me - every http connection from the
nomad client goes to the same NOMAD_ADDR so it's a great case for keep
alive. Except round robin DNS and anycast perhaps.

Consul does this already
https://github.com/hashicorp/consul/blob/1e47e3c82b6eb937baab0688a67cf7ef334ce42c/api/api.go#L397
    @tgross
    Ben Buzbee authored and tgross committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a5f3b6f View commit details
    Browse the repository at this point in the history

  2. changelog entry

    @tgross
    tgross committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b69cadb View commit details
    Browse the repository at this point in the history