Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disconnected clients: TaskGroup validation #12418

Conversation

DerekStrickland
Copy link
Contributor

Added validation logic that both max_client_disconnect and stop_after_client_disconnect cannot be configured at the same time for the same task group.

@DerekStrickland DerekStrickland added this to the 1.3.0 milestone Mar 31, 2022
@DerekStrickland DerekStrickland self-assigned this Mar 31, 2022
…after_client_disconnect cannot both be set
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vercel vercel bot temporarily deployed to Preview – nomad March 31, 2022 15:49 Inactive
@DerekStrickland DerekStrickland merged commit ff9ed55 into f-disconnected-client-allocation-handling Mar 31, 2022
@DerekStrickland DerekStrickland deleted the f-validate-config-disconnected-clients branch March 31, 2022 17:34
DerekStrickland added a commit that referenced this pull request Apr 5, 2022
* TaskGroup: Validate that max_client_disconnect and stop_after_client_disconnect are mutually exclusive.
DerekStrickland added a commit that referenced this pull request Apr 6, 2022
* TaskGroup: Validate that max_client_disconnect and stop_after_client_disconnect are mutually exclusive.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants