Commits on Apr 5, 2022

1. CSI: don't block client shutdown for node unmount …

   When we unmount a volume we need to be able to recover from cases
   where the plugin has been shutdown before the allocation that needs
   it, so in #11892 we blocked shutting down the alloc runner hook. But
   this blocks client shutdown if we're in the middle of unmounting. The
   client won't be able to communicate with the plugin or send the
   unpublish RPC anyways, so we should cancel the context and assume that
   we'll resume the unmounting process when the client restarts.
   
   For `-dev` mode we don't send the graceful `Shutdown()` method and
   instead destroy all the allocations. In this case, we'll never be able
   to communicate with the plugin but also never close the context we
   need to prevent the hook from blocking. To fix this, move the retries
   into their own goroutine that doesn't block the main `Postrun`.

   

   tgross committed Apr 5, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 650757a
   • Browse repository at this point

   Copy the full SHA

   650757a View commit details

   Browse the repository at this point in the history