docs: updates for CSI plugin improvements for 1.3.0 #12466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
changed the title
shoenig
approved these changes
Apr 5, 2022
| tasks last. | ||
|
|
||
| Typically, you should run node plugins as Nomad `system` jobs so they | ||
| can mount volumes on any client in a datacenter. Controller plugins |
There was a problem hiding this comment.
Suggested change
| can mount volumes on any client in a datacenter. Controller plugins | |
| can mount volumes on any client in a cluster. Controller plugins |
Unless datacenter is intentional (?)
There was a problem hiding this comment.
It was intentional, because a system job runs across the specific datacenter they're deployed in and not the whole cluster. But on second thought there can be more than 1 DC for a given system job and that makes it read awkwardly. Maybe "can mount volumes on any client where they are running"?
tgross
added a commit
that referenced
this pull request
Apr 20, 2022
tgross
added a commit
that referenced
this pull request
Apr 20, 2022
This was referenced Apr 20, 2022
tgross
added a commit
that referenced
this pull request
Apr 20, 2022
tgross
added a commit
that referenced
this pull request
Apr 20, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview links: